[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_JsqLahLTk9cjKhVct7OF7VNw7yyO-uTv6Hw-tqUSELaPm4A@mail.gmail.com>
Date: Wed, 30 Mar 2016 07:54:04 -0500
From: Rob Herring <robh@...nel.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Andy Gross <andy.gross@...aro.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-soc@...r.kernel.org
Subject: Re: [PATCH 10/12] ARM: dts: dragonboard-600c: Add on board leds support
On Sun, Mar 27, 2016 at 12:50 AM, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
> On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote:
>
>> This patch adds support to 4 user leds, wlan and bt led on board.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>
> I'm not fond of the overly complicated names; and I think it should at
> least be shortened to "db600c:...".
These names are exposed to userspace. They should be the same across
all 96boards. Same goes for UART numbering and I2C bus labels on the
connector.
> Tested this on my DB600c, seems to work, except the WiFi/BT triggers,
> see comments below.
>
>> + leds {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&user_leds>, <&mpp_leds>;
>> +
>> + compatible = "gpio-leds";
>> +
>> + led@1 {
unit-address w/o reg property will warn on new dtc. I'd suggest
something like "userX-led".
>> + label = "dragonboard-600c:green:user1";
>> + gpios = <&tlmm_pinmux 3 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
Powered by blists - more mailing lists