linux-kernel - Re: [PATCH] MIPS: ath79: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160330221329.25ca0849d782e55c0564f139@gmail.com>
Date:	Wed, 30 Mar 2016 22:13:29 +0300
From:	Antony Pavlov <antonynpavlov@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: ath79: fix build failure

On Wed, 30 Mar 2016 16:29:49 +0100
Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

> The ath79_defconfig build of mips was faling with the errors:
> 
> arch/mips/ath79/setup.c: In function 'plat_mem_setup':
> arch/mips/ath79/setup.c:226:20: error: invalid storage class for function 'ath79_of_plat_time_init'
>  static void __init ath79_of_plat_time_init(void)
>                     ^
> arch/mips/ath79/setup.c:226:1: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
>  static void __init ath79_of_plat_time_init(void)
>  ^
> arch/mips/ath79/setup.c:284:20: error: invalid storage class for function 'ath79_setup'
>  static  __init int ath79_setup(void)
>                     ^
> arch/mips/ath79/setup.c:299:1: error: initializer element is not constant
>  arch_initcall(ath79_setup);
> 
> It turns out to be a simple error of a missed closing brace.
> 
> Fixes: f63ba725caa7 ("MIPS: ath79: Disable platform code for OF boards.")
> Cc: Antony Pavlov <antonynpavlov@...il.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> ---
> 
> Build log of next-20160330 is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119417999
> 
>  arch/mips/ath79/setup.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c
> index 897f49a..e0ff6f3 100644
> --- a/arch/mips/ath79/setup.c
> +++ b/arch/mips/ath79/setup.c
> @@ -214,6 +214,7 @@ void __init plat_mem_setup(void)
>  						 AR71XX_PLL_SIZE);
>  		ath79_detect_sys_type();
>  		ath79_ddr_ctrl_init();
> +	}
>  
>  	detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
>  	/* OF machines should use the reset driver */

It is very strange because my original patch has this closing brace.
Please see my original patch
https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html

Also I suppose that we have no need in detect_memory_region() if we use devicetree,
e.g.

                ath79_detect_sys_type();
                ath79_ddr_ctrl_init();
 +              detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
 +      }
  
 -      detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);


-- 
Best regards,
  Antony Pavlov