linux-kernel - Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8760w4bl1m.fsf@kamboji.qca.qualcomm.com>
Date:	Wed, 30 Mar 2016 08:18:45 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	kbuild test robot <lkp@...el.com>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pontus Fuchs <pontus.fuchs@...il.com>, kbuild-all@...org,
	wcn36xx@...ts.infradead.org,
	Eugene Krasnikov <k.eugene.e@...il.com>
Subject: Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

Bjorn Andersson <bjorn.andersson@...aro.org> writes:

>> All error/warnings (new ones prefixed by >>):
>> 
>>    drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key':
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit declaration of function 'wcn36xx_sta_to_priv' [-Werror=implicit-function-declaration]
>>      struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>>             ^
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:33: warning: initialization makes pointer from integer without a cast
>>      struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>>                                     ^
>>    cc1: some warnings being treated as errors
>
> This should have been reordered with patch 7, that introduces this
> helper function. Do you want me to resend, or can you apply the patches
> out of order?

It's better that you resend the whole patchset as v2.

-- 
Kalle Valo