linux-kernel - Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FCB0F3.4060908@monom.org>
Date:	Thu, 31 Mar 2016 07:09:07 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Tom Zanussi <tom.zanussi@...ux.intel.com>, rostedt@...dmis.org,
	masami.hiramatsu.pt@...achi.com, josh@...htriplett.org,
	andi@...stfloor.org, mathieu.desnoyers@...icios.com,
	peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier

Hi Namhyung,

On 03/29/2016 05:17 PM, Namhyung Kim wrote:
> On Tue, Mar 29, 2016 at 12:01:40PM +0200, Daniel Wagner wrote:
>> cat /sys/kernel/debug/tracing/events/test/latency_complete/hist
>> # event histogram
>> #
>> # trigger info: hist:keys=latency.log2:vals=hitcount:sort=latency.log2:size=2048 [active]
>> #
>> #
> 
> Maybe we want to skip printing those flags for sort keys..
> What about this?

Yes, something like this makes sense to me. As I said, it is only a
minor detail and maybe just not worth the extra code.

Anyway, the hist patches do really work nicely. I hope they get merged soon.

cheers,
daniel