linux-kernel - Re: [PATCH v8] acpi, apei, arm64: APEI initial support for aarch64.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-_YhFva9RHUtzC68Ck2wTN2BvcXTEfCJbvVh98DFgn_A@mail.gmail.com>
Date:	Thu, 31 Mar 2016 09:52:54 +0200
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Fu Wei <fu.wei@...aro.org>
Cc:	kbuild test robot <lkp@...el.com>,
	Mark Rutland <mark.rutland@....com>,
	Linaro ACPI Mailman List <linaro-acpi@...ts.linaro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	"Baicar, Tyler" <tbaicar@...eaurora.org>,
	Will Deacon <will.deacon@....com>,
	Richard Ruigrok <rruigrok@...eaurora.org>, pavel@....cz,
	"hpa@...or.com" <hpa@...or.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Al Stone <al.stone@...aro.org>,
	Tomasz Nowicki <tn@...ihalf.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"Abdulhamid, Harb" <harba@....qualcomm.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	Mark Salter <msalter@...hat.com>,
	Grant Likely <grant.likely@...aro.org>,
	Hanjun Guo <hanjun.guo@...aro.org>, len.brown@...el.com,
	linux-pm@...r.kernel.org, Marc Zyngier <Marc.Zyngier@....com>,
	Jon Masters <jcm@...hat.com>,
	Tomasz Nowicki <tomasz.nowicki@...aro.org>,
	Robert Richter <rrichter@...ium.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	G Gregory <graeme.gregory@...aro.org>,
	Rafael Wysocki <rjw@...ysocki.net>,
	LKML <linux-kernel@...r.kernel.org>,
	jarkko.nikula@...ux.intel.com, kbuild-all@...org,
	Jonathan Zhang <jon.zhixiong.zhang@...il.com>
Subject: Re: [PATCH v8] acpi, apei, arm64: APEI initial support for aarch64.

On 30 March 2016 at 19:55, Fu Wei <fu.wei@...aro.org> wrote:
> Hi Tomasz
>
> On 30 March 2016 at 14:50, kbuild test robot <lkp@...el.com> wrote:
>> Hi Tomasz,
>>
>> [auto build test WARNING on arm64/for-next/core]
>> [also build test WARNING on v4.6-rc1 next-20160330]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-apei-arm64-APEI-initial-support-for-aarch64/20160329-154730
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux for-next/core
>> config: arm64-allyesconfig (attached as .config)
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=arm64
>>
>> All warnings (new ones prefixed by >>):
>>
>> warning: (ACPI_APEI) selects EFI which has unmet direct dependencies (OF && !CPU_BIG_ENDIAN)
>
> I think it's caused by  CPU_BIG_ENDIAN, because  ARM64 selects OF.
>

No, as I pointed out, it is caused by the fact that you 'select' EFI
rather than 'depend on' it.

> Any suggestion ?
>

replace

select EFI if ARM64

with

depends on EFI || !ARM64

but it would be even better to make ACPI_APEI depend on ACPI, since
the above dependency will be implied then, although I am not sure how
that affects other architectures.

-- 
Ard.