linux-kernel - Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcJ92vB-b7daMpd2i9hP4MPU2CAQf7JoiBx5rKFvB1RVw@mail.gmail.com>
Date:	Thu, 31 Mar 2016 16:25:22 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	qiujiang <qiujiang@...wei.com>
Cc:	Alan Tull <delicious.quinoa@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jamie Iles <jamie@...ieiles.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	linuxarm@...wei.com, haifeng.wei@...wei.com,
	charles.chenxin@...wei.com, atull <atull@...nsource.altera.com>
Subject: Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

On Thu, Mar 31, 2016 at 3:51 AM, Jiang Qiu <qiujiang@...wei.com> wrote:
> 在 2016/3/30 19:38, Andy Shevchenko 写道:

>>> One suggestion for both patches: you could remove name from struct
>>> dwapb_port_property and get rid of pp->name and nobody would miss it.
>>> All it is used for is some dev_err's so the device info gets printed
>>> anyway.  For example (if I leave the irq out of the DT)
>>>
>>> gpio-dwapb ff708000.gpio: no irq for bank /soc/gpio@...08000/gpio-controller@0
>>>
>>> is redundant.  The only additional info here from the name is the port
>>> index.  That could be added to the messages without having to get the
>>> name through the two property/of methods.
>>>
>>
>> Good suggestion! That'll make patches and code cleaner.
>>
>> Perhaps separate prepended  patch?
>>
> Hi Alan/Andy,
>
> It sounds good, I will follow this suggestion and do a test. But, what's the
> "separate prepended patch" mean?

Preparatory patch which goes first in the series.

-- 
With Best Regards,
Andy Shevchenko