linux-kernel - Re: arm:collie_defconfig broken since commit ff2b135922 ("gpio: make the gpiochip a real device")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160331141849.GA28107@roeck-us.net>
Date:	Thu, 31 Mar 2016 07:18:49 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: arm:collie_defconfig broken since commit ff2b135922 ("gpio: make
 the gpiochip a real device")

On Thu, Mar 31, 2016 at 03:26:49PM +0200, Linus Walleij wrote:
> On Mon, Mar 28, 2016 at 7:03 AM, Guenter Roeck <linux@...ck-us.net> wrote:
> 
> > arm:collie_defconfig is broken since commit ff2b135922 ("gpio: make the
> > gpiochip a real device").
> 
> Oh I was worried that something like this would happen, but
> hoped we could find it in linux-next, oh well.
> 
I didn't have collie_defconfig in my list of qemu tests since last weekend.
Shows that qemu boot tests _are_ valuable ;-).

Question is how to get to a real solution. I tried calling gpiolib_dev_init()
from gpiochip_add_data() if gpiolib was not initialized yet, but at least for
collie this doesn't work, presumably since gpiochip_add_data() is called too
early. I am currently looking into deferring device initialization from
gpiochip_add_data() until gpiolib_dev_init() was called, as suggested by
Alexandre.

Guenter