linux-kernel - RE: [PATCH] tpm: cleanup tpm_tis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8646C2A85C5D44419E1B33F16B0BD501024AFA6B6E@SAFEX1MAIL1.st.com>
Date:	Thu, 31 Mar 2016 16:55:50 +0200
From:	Christophe Henri RICARD <christophe-h.ricard@...com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:	Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@...ts.sourceforge.net>,
	open list <linux-kernel@...r.kernel.org>,
	Peter Huewe <peterhuewe@....de>,
	Christophe Ricard <christophe.ricard@...il.com>
Subject: RE: [PATCH] tpm: cleanup tpm_tis_remove()

Tested-by: Christophe Ricard <christophe-h.ricard@...com>

-----Original Message-----
From: Jarkko Sakkinen [mailto:jarkko.sakkinen@...ux.intel.com] 
Sent: jeudi 31 mars 2016 12:30
To: Christophe Henri RICARD
Cc: Marcel Selhorst; Jason Gunthorpe; moderated list:TPM DEVICE DRIVER; open list; Peter Huewe
Subject: Re: [PATCH] tpm: cleanup tpm_tis_remove()

On Thu, Mar 31, 2016 at 01:17:13PM +0300, Jarkko Sakkinen wrote:
> On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> > Christophe,
> > 
> > On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > > Created a local variable for the register in order to clean up 
> > > experession where TPM_GLOBAL_INT_ENABLE is cleared. This 
> > > expression is horrible to read and makes changing the function 
> > > uncomfortable because like easily surpass 80 characters.
> > 
> > Can you test this patch your hardware and reply with Tested-by tag 
> > if it does? I can then update your iobase patch to apply on top of this.
> > 
> > I thought it was better idea to simplify the expression a little bit 
> > than make it even worse mess.
> 
> And yes  I'll fix all the typos in the commit msg in this patch before 
> applying it :)

I committed this to my master branch with the option to drop if there it does not get reviewed/tested-by's (which I doubt). Since this touches multiple patches (locality patch too) and in addition there was couple glitches maybe it would be good if you would prepare one more round of the series if you don't mind?

/Jarkko