linux-kernel - Re: [PATCH v2 2/3] ata: ahci-platform: Add ports-implemented DT bindings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160331173407.GE24661@htj.duckdns.org>
Date:	Thu, 31 Mar 2016 13:34:07 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	linux-ide@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Andy Gross <andy.gross@...aro.org>,
	Hans de Goede <hdegoede@...hat.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, jmaggard10@...il.com
Subject: Re: [PATCH v2 2/3] ata: ahci-platform: Add ports-implemented DT
 bindings.

On Thu, Mar 31, 2016 at 06:31:39PM +0100, Srinivas Kandagatla wrote:
> On some SOCs PORTS_IMPL register value is never programmed by the
> firmware and left at zero value. Which means that no sata ports are
> available for software. AHCI driver used to cope up with this by
> fabricating the port_map if the PORTS_IMPL register is read zero,
> but recent patch broke this workaround as zero value was valid for
> NVMe disks.
> 
> This patch adds ports-implemented DT bindings as workaround for this issue
> in a way that DT can can override the PORTS_IMPL register in cases where
> the firmware did not program it already.
> 
> Fixes: 566d1827df2e ("libata: disable forced PORTS_IMPL for >= AHCI 1.3)
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

For 1 and 2,

Acked-by: Tejun Heo <tj@...nel.org>

I can route all three through libata/for-4.6-fixes once the platform
side is acked.  If it's better to route these through the platform
tree, please feel free to do so.

Thanks.

-- 
tejun