linux-kernel - Re: [media 7/8] PCIE bridge driver for PT3 & PX-Q3PE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201604011220.3urAH9i3%fengguang.wu@intel.com>
Date:	Fri, 1 Apr 2016 12:13:07 +0800
From:	kbuild test robot <lkp@...el.com>
To:	info@....ma
Cc:	kbuild-all@...org, linux-media@...r.kernel.org,
	Буди Романто, AreMa Inc 
	<knightrider@....ma>, linux-kernel@...r.kernel.org, crope@....fi,
	m.chehab@...sung.com, mchehab@....samsung.com, hdegoede@...hat.com,
	laurent.pinchart@...asonboard.com, mkrufky@...uxtv.org,
	sylvester.nawrocki@...il.com, g.liakhovetski@....de,
	peter.senna@...il.com
Subject: Re: [media 7/8] PCIE bridge driver for PT3 & PX-Q3PE

Hi Буди,

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.6-rc1 next-20160331]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/info-are-ma/DVB-driver-for-Earthsoft-PT3-PLEX-PX-Q3PE-ISDB-S-T-PCIE-cards-PX-BCUD-ISDB-S-USB-dongle/20160401-034740
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/media/pci/ptx/pxq3pe_pci.c: In function 'pxq3pe_remove':
   drivers/media/pci/ptx/pxq3pe_pci.c:484:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
      vfree(p->sBuf);
      ^
   drivers/media/pci/ptx/pxq3pe_pci.c: In function 'pxq3pe_probe':
   drivers/media/pci/ptx/pxq3pe_pci.c:536:14: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
      p->sBuf  = vzalloc(p->sBufSize);
                 ^
>> drivers/media/pci/ptx/pxq3pe_pci.c:536:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      p->sBuf  = vzalloc(p->sBufSize);
               ^
   cc1: some warnings being treated as errors

vim +536 drivers/media/pci/ptx/pxq3pe_pci.c

   478		if (c->dma.dat)
   479			pci_free_consistent(card->pdev, c->dma.sz, c->dma.dat, c->dma.adr);
   480		for (i = 0; i < card->adapn; i++) {
   481			struct ptx_adap		*adap	= &card->adap[i];
   482			struct pxq3pe_adap	*p	= adap->priv;
   483	
 > 484			vfree(p->sBuf);
   485		}
   486		if (c->bar)
   487			pci_iounmap(pdev, c->bar);
   488		ptx_unregister_adap(card);
   489	}
   490	
   491	static const struct i2c_algorithm pxq3pe_algo = {
   492		.functionality	= ptx_i2c_func,
   493		.master_xfer	= pxq3pe_xfr,
   494	};
   495	
   496	static int pxq3pe_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
   497	{
   498		struct ptx_subdev_info	pxq3pe_subdev_info[] = {
   499			{SYS_ISDBT, 0x20, TC90522_MODNAME, 0x10, NM131_MODNAME},
   500			{SYS_ISDBS, 0x22, TC90522_MODNAME, 0x11, TDA2014X_MODNAME},
   501			{SYS_ISDBT, 0x24, TC90522_MODNAME, 0x12, NM131_MODNAME},
   502			{SYS_ISDBS, 0x26, TC90522_MODNAME, 0x13, TDA2014X_MODNAME},
   503			{SYS_ISDBT, 0x28, TC90522_MODNAME, 0x14, NM131_MODNAME},
   504			{SYS_ISDBS, 0x2A, TC90522_MODNAME, 0x15, TDA2014X_MODNAME},
   505			{SYS_ISDBT, 0x2C, TC90522_MODNAME, 0x16, NM131_MODNAME},
   506			{SYS_ISDBS, 0x2E, TC90522_MODNAME, 0x17, TDA2014X_MODNAME},
   507		};
   508		struct ptx_card		*card	= ptx_alloc(pdev, KBUILD_MODNAME, ARRAY_SIZE(pxq3pe_subdev_info),
   509							sizeof(struct pxq3pe_card), sizeof(struct pxq3pe_adap), pxq3pe_lnb);
   510		struct pxq3pe_card	*c;
   511		u8	regctl	= 0xA0,
   512			i;
   513		u16	cfg;
   514		int	err	= !card || pci_read_config_word(pdev, PCI_COMMAND, &cfg);
   515	
   516		if (err)
   517			return ptx_abort(pdev, pxq3pe_remove, err, "Memory/PCI error, card=%p", card);
   518		c	= card->priv;
   519		if (!(cfg & PCI_COMMAND_MASTER)) {
   520			pci_set_master(pdev);
   521			pci_read_config_word(pdev, PCI_COMMAND, &cfg);
   522			if (!(cfg & PCI_COMMAND_MASTER))
   523				return ptx_abort(pdev, pxq3pe_remove, -EIO, "Bus Mastering is disabled");
   524		}
   525		c->bar	= pci_iomap(pdev, 0, 0);
   526		if (!c->bar)
   527			return ptx_abort(pdev, pxq3pe_remove, -EIO, "I/O map failed");
   528		if (ptx_i2c_add_adapter(card, &pxq3pe_algo))
   529			return ptx_abort(pdev, pxq3pe_remove, -EIO, "Cannot add I2C");
   530	
   531		for (i = 0; i < card->adapn; i++) {
   532			struct ptx_adap		*adap	= &card->adap[i];
   533			struct pxq3pe_adap	*p	= adap->priv;
   534	
   535			p->sBufSize	= PTX_TS_SIZE * 100 << 9;
 > 536			p->sBuf		= vzalloc(p->sBufSize);
   537			if (!p->sBuf)
   538				return ptx_abort(pdev, pxq3pe_remove, -ENOMEM, "No memory for stream buffer");
   539		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (54429 bytes)