linux-kernel - Legal characters in encrypted fscrypto (f2fs/ext4) filename?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160401060018.GD1323@zzz>
Date:	Fri, 1 Apr 2016 01:00:18 -0500
From:	Eric Biggers <ebiggers3@...il.com>
To:	linux-fsdevel@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net, linux-ext4@...r.kernel.org,
	jaegeuk@...nel.org, tytso@....edu, mhalcrow@...gle.com
Subject: Legal characters in encrypted fscrypto (f2fs/ext4) filename?

Hello,

While reviewing the new filesystem encryption code, I was confused by the
intended set of legal characters in the printable form of an encrypted filename.

According to the actual code in fs/crypto/fname.c, the legal characters are:

	a-zA-Z0-9+,

Alternatively, according to the comment in the same file, the legal characters
are actually:

	a-zA-Z0-9+_

Still alternatively, according to the design document[1], the legal characters
are actually:

	a-zA-Z0-9+=

Which one is correct?

[1] https://docs.google.com/document/d/1ft26lUQyuSpiu6VleP70_npaWdRfXFoNnB8JYnykNTg/preview?pref=2&pli=1#