linux-kernel - Re: [PATCH v2] module: fix noreturn attribute for __module_put_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1604010830240.3656@cbobk.fhfr.pm>
Date:	Fri, 1 Apr 2016 08:31:05 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] module: fix noreturn attribute for
 __module_put_and_exit()

On Fri, 1 Apr 2016, Rusty Russell wrote:

> >> __module_put_and_exit() is makred noreturn in module.h declaration, but is
> >> lacking the attribute in the definition, which makes some tools (such as
> >> sparse) unhappy. Amend the definition with the attribute as well (and
> >> reformat the declaration so that it uses more common format).
> >> 
> >> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> >> ---
> >> 
> >> v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested 
> >> 	  by Rusty
> >
> > Rusty, friendly ping on this one.
> >
> > Thanks!
> 
> Oops, I applied it, and in testing noted that lguest had broken and
> ended up getting distracted by that.  I've acked it now (it will
> probably wait until next merge window).

Sorry, non comprende :) Could you please elaborate? Are you saying this 
patch broke lguest? What is the breakage about?

Thanks,

-- 
Jiri Kosina
SUSE Labs