linux-kernel - Re: [PATCH 2/2] gpiolib: Defer gpio device setup until after gpiolib initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Apr 2016 10:14:03 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Ungerer <gerg@...inux.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH 2/2] gpiolib: Defer gpio device setup until after gpiolib initialization

On Thu, Mar 31, 2016 at 5:11 PM, Guenter Roeck <linux@...ck-us.net> wrote:

> Since commit ff2b13592299 ("gpio: make the gpiochip a real device"),
> attempts to add a gpio chip prior to gpiolib initialization cause
> the system to crash. This happens because gpio_bus_type has not been
> registered yet. Defer creating gpio devices until after gpiolib has
> been initialized to fix the problem.
>
> Cc: Greg Ungerer <gerg@...inux.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Fixes: ff2b13592299 ("gpio: make the gpiochip a real device")
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Very elegant solution and also a nice refactoring.

Patches applied for fixes and I'm pushing it for test so we get
some rotation in linux-next.

Yours,
Linus Walleij