linux-kernel - Re: [PATCH] iio: max5487: Add support for Maxim digital potentiometers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBBVuYSBNPXTTSR0UeiQa8UH8TVndzn5AhrWWYp-iSQKA@mail.gmail.com>
Date:	Fri, 1 Apr 2016 11:28:52 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Peter Rosin <peda@...ntia.se>
Cc:	Cristina Moraru <cristina.moraru09@...il.com>,
	"jic23@...nel.org" <jic23@...nel.org>,
	"knaack.h@....de" <knaack.h@....de>,
	"lars@...afoo.de" <lars@...afoo.de>,
	"pmeerw@...erw.net" <pmeerw@...erw.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"daniel.baluta@...el.com" <daniel.baluta@...el.com>,
	"octavian.purdila@...el.com" <octavian.purdila@...el.com>
Subject: Re: [PATCH] iio: max5487: Add support for Maxim digital potentiometers

> .wipers and .max_pos need not be in max5487_cfg, they are common.
> .wipers isn't even used. Which means that if you like, you can
> use the ohms reading as the driver_data directly instead of going
> via the MAX548x enumeration, see below. Or is there some reason
> not doing so?

You make a good point. Anyhow we thought of a generic approach. In the future
this chip family could support more wipers with different positions.