linux-kernel - Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FE4554.9090702@ti.com>
Date:	Fri, 1 Apr 2016 12:54:28 +0300
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Nishanth Menon <nm@...com>, Chanwoo Choi <cw00.choi@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Tony Lindgren <tony@...mide.com>,
	Lee Jones <lee.jones@...aro.org>, Roger Quadros <rogerq@...com>
Subject: Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag

On 04/01/2016 12:15 AM, Nishanth Menon wrote:
> Palams extcon IRQs are nested threaded and wired to the Palmas
> inerrupt controller. So, this flag is not required for nested
> irqs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged. However, the
> fix missed a stray flag causing the following crash on resume on

Ok. Sry, my bad I've had to check next.
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

>
> Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag")
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Roger Quadros <rogerq@...com>
>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>   drivers/extcon/extcon-palmas.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 841a4b586395..8b3226dca1d9 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -348,8 +348,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>   						palmas_vbus_irq_handler,
>   						IRQF_TRIGGER_FALLING |
>   						IRQF_TRIGGER_RISING |
> -						IRQF_ONESHOT |
> -						IRQF_EARLY_RESUME,
> +						IRQF_ONESHOT,
>   						"palmas_usb_vbus",
>   						palmas_usb);
>   		if (status < 0) {
>


-- 
regards,
-grygorii