linux-kernel - Re: [PATCH v3 3/3] perf tools: Hook up MIPS unwind and dwarf-regs in the Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56FE545A.7090003@cogentembedded.com>
Date:	Fri, 1 Apr 2016 13:58:34 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ralf Baechle <ralf@...ux-mips.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	David Daney <david.daney@...ium.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Burton <paul.burton@...tec.com>,
	James Hogan <james.hogan@...tec.com>,
	Matt Redfearn <matt.redfearn@...tec.com>,
	Qais Yousef <qais.yousef@...tec.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Jiri Olsa <jolsa@...hat.com>, Wang Nan <wangnan0@...wei.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Stephane Eranian <eranian@...gle.com>,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] perf tools: Hook up MIPS unwind and dwarf-regs in
 the Makefile

Hello.

On 4/1/2016 11:56 AM, Ralf Baechle wrote:

> From: David Daney <david.daney@...ium.com>
>
> Define a new symbol (ARCH_SUPPORTS_LIBUNWIND) in config/Makefile.

    Eh? Where is it?

> Use this from x86 and MIPS to gate testing of libunwind.

    x86? Where?

> Signed-off-by: David Daney <david.daney@...ium.com>
> Cc: linux-mips@...ux-mips.org
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> ---
>   tools/perf/config/Makefile | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index f7d7f5a..713c69c 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -51,6 +51,11 @@ ifeq ($(NO_PERF_REGS),0)
>     $(call detected,CONFIG_PERF_REGS)
>   endif
>
> +ifeq ($(ARCH),mips)
> +  NO_PERF_REGS := 0
> +  LIBUNWIND_LIBS = -lunwind -lunwind-mips
> +endif
> +
>   # So far there's only x86 and arm libdw unwind support merged in perf.
>   # Disable it on all other architectures in case libdw unwind
>   # support is detected in system. Add supported architectures

MBR, Sergei