linux-kernel - Re: [PATCH] sched/clock: Remove pointless test in cpu_clock/local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160401151017.GK3448@twins.programming.kicks-ass.net>
Date:	Fri, 1 Apr 2016 17:10:17 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	"open list:SCHEDULER" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/clock: Remove pointless test in
 cpu_clock/local_clock

On Fri, Apr 01, 2016 at 03:46:48PM +0200, Daniel Lezcano wrote:

> Remove the duplicate test by directly calling sched_clock_cpu() and let the
> static key act in this function instead. We can assume gcc is smart enough to
> inline cpu_clock()/local_clock() to sched_clock_cpu().

Why assume if you can easily check; so does it indeed inline?