lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 1 Apr 2016 09:22:17 -0700
From:	Peter Hurley <peter@...leysoftware.com>
To:	Dominique van den Broeck <domdevlin@...e.fr>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Shraddha Barke <shraddha.6596@...il.com>,
	Radek Dostal <rd@...ekdostal.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: fwserial: (coding style) Turning every
 "unsigned" into "unsigned int"

On 03/29/2016 10:14 AM, Dominique van den Broeck wrote:
> Coding-style-only modifications to remove every warning saying:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> 
> Compiled against revision "next-20160327".
> 
> (checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings
>  as of commit a1ce18e4f941d20 )

Please change $subject to "staging: fwserial: Convert unsigned to unsigned int"
With that,

Reviewed-by: Peter Hurley <peter@...leysoftware.com>


PS - For v2 of this patch, be sure to change the subject prefix to [PATCH v2 ...],
and note any changes in the diffstat area of the patch itself; eg.,


Signed-off-by: Dominique van den Broeck <domdevlin@...e.fr>
---

v2: change subject per Peter Hurley's comments


 drivers/staging/fwserial/dma_fifo.c |  8 +++----
 drivers/staging/fwserial/dma_fifo.h | 16 +++++++-------
 drivers/staging/fwserial/fwserial.c | 38 +++++++++++++++++----------------
 drivers/staging/fwserial/fwserial.h | 42 ++++++++++++++++++-------------------
 4 files changed, 53 insertions(+), 51 deletions(-)




Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ