linux-kernel - Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1459536253.1744.26.camel@perches.com>
Date:	Fri, 01 Apr 2016 11:44:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	James Simmons <jsimmons@...radead.org>
Cc:	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<lustre-devel@...ts.lustre.org>" <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [RFC PATCH 0/3] staging: lustre: detypedef

On Fri, 2016-04-01 at 14:23 +0000, Drokin, Oleg wrote:
> On Apr 1, 2016, at 9:02 AM, Joe Perches wrote:
> > 
> > Question about removing lustre typedefs.
> > 
> > Various bits of lustre code use a mix of struct foo and foo_t.
> > 
> > When would be an appropriate time to submit patches similar to
> > below that individually remove various typedefs from lustre code?
> I think now is as good time as any.
> the only small correction is those are LNet typedefs.
> While LNet is technically part of Lustre, it's a bit of a separate
> thing useful without Lustre too.
> 
> I know James is working on cleaning up LNet, but I don't know if he has
> anything this would be conflicting at this moment or not.
> 
> Thanks for the patches. I wonder if you are generating them automatically?
> Because it would be great if it also fixes the alignment issues

It's pretty automatic.

It's a trivial variant of the detypedef perl script I wrote awhile ago:
http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/18603


I think changing the alignment issues is better done in a
separate patch.

James isn't cc'd on these patches as he's not a listed
maintainer.  Maybe he should be added for all of it or
some part of it?

I don't know what email address James prefers as there
are several in git log for him.

James Simmons <uja.ornl@...oo.com>
James Simmons <uja.ornl@...il.com>
James Simmons <jsimmons@...radead.org>
"Simmons, James A." <simmonsja@...l.gov>

but maybe something like this:
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 16ccda4..d585631 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10578,6 +10578,7 @@ F:	drivers/staging/media/lirc/
 STAGING - LUSTRE PARALLEL FILESYSTEM
 M:	Oleg Drokin <oleg.drokin@...el.com>
 M:	Andreas Dilger <andreas.dilger@...el.com>
+R:	James Simmons <jsimmons@...radead.org>
 L:	lustre-devel@...ts.lustre.org (moderated for non-subscribers)
 W:	http://wiki.lustre.org/
 S:	Maintained