linux-kernel - Re: [PATCH 4/4] efi: A misc char interface to update EFI firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1459478930.6099.249.camel@nexus-software.ie>
Date:	Fri, 01 Apr 2016 03:48:50 +0100
From:	deckard <pure.logic@...us-software.ie>
To:	Matt Fleming <matt@...eblueprint.co.uk>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	joeyli <jlee@...e.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Borislav Petkov <bp@...en8.de>,
	Andy Lutomirski <luto@...capital.net>,
	Sam Protsenko <semen.protsenko@...aro.org>,
	Peter Jones <pjones@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4/4] efi: A misc char interface to update EFI firmware

On Thu, 2016-03-17 at 12:57 +0000, Matt Fleming wrote:
> Tested with Intel Quark Galileo GEN1 platform.

+ * If the capsule is successfully submitted to the firmware, any
+ * subsequent calls to efi_capsule_pending() will return true. @pages
+ * must not be released or modified if this function returns
+ * successfully.

The only minor nit here is that you can't actually test this on a
Galileo GEN1 since there's a non-standard header required to update the
firmware on that platform !

So I suggest dropping that particular comment in the git log, since you
can't actually *do* that on a Galileo without doing something about the
required CSH (Clanton Secure Header) prefixed to the standard Capsule
header.

Otherwise.

Reviewed-by: Bryan O'Donoghue <pure.logic@...us-software.ie>