linux-kernel - Re: [PATCH] staging: vme: fix bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Apr 2016 21:36:31 +0100
From:	Martyn Welch <mwelchuk@...il.com>
To:	Clifton Barnes <clifton.a.barnes@...il.com>, martyn@...chs.me.uk,
	manohar.vanga@...il.com, gregkh@...uxfoundation.org
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: vme: fix bare use of 'unsigned'



On 31/03/16 23:53, Clifton Barnes wrote:
> fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
> 'unsigned''
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@...il.com>

Acked-by: Martyn Welch <martyn@...chs.me.uk>

Greg: Whilst this patch seems valid and compiles fine, I no longer have 
access to the hardware for this driver. I'm aware this driver has been 
in the staging tree for a rather long time. I will check to see if 
there's any intention for further work to be done on this driver, if not 
I guess we should be looking to delete it from the staging tree.

Martyn

> ---
>   drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c
> index df992c3..f52a9ed 100644
> --- a/drivers/staging/vme/devices/vme_pio2_gpio.c
> +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c
> @@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip,
>   }
>   
>   /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset)
>   {
>   	int data;
>   	struct pio2_card *card = gpio_to_pio2_card(chip);
> @@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
>   }
>   
>   /* Directionality configured at board build - send appropriate response */
> -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value)
> +static int pio2_gpio_dir_out(struct gpio_chip *chip,
> +			     unsigned int offset, int value)
>   {
>   	int data;
>   	struct pio2_card *card = gpio_to_pio2_card(chip);