linux-kernel - Re: [PATCH v5 1/4] perf config: Introduce perf_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 17:13:31 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Taeung Song <treeze.taeung@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v5 1/4] perf config: Introduce perf_config_set class

Hi,

2016-04-03 2:08 GMT+09:00 Taeung Song <treeze.taeung@...il.com>:
[...]
> +static struct perf_config_section *add_section(struct list_head *sections,
> +                                              const char *section_name)
> +{
> +       struct perf_config_section *section = zalloc(sizeof(*section));
> +
> +       if (!section)
> +               return NULL;
> +
> +       INIT_LIST_HEAD(&section->items);
> +       section->name = strdup(section_name);
> +       if (!section->name) {
> +               pr_debug("%s: strdup failed\n", __func__);
> +               free(section);
> +               return NULL;
> +       }
> +
> +       list_add_tail(&section->node, sections);
> +       return section;
> +}
> +
> +static struct perf_config_item *add_config_item(struct perf_config_section *section,
> +                                               const char *name)
> +{
> +       struct perf_config_item *item = zalloc(sizeof(*item));
> +
> +       if (!item)
> +               return NULL;
> +
> +       item->name = strdup(name);
> +       if (!item->name) {
> +               pr_debug("%s: strdup failed\n", __func__);
> +               goto out_err;

As you did in above add_section(), you can do free(item)
and return NULL here instead of using goto.

Other parts looks OK for me.

Thank you,

> +       }
> +
> +       list_add_tail(&item->node, &section->items);
> +       return item;
> +
> +out_err:
> +       free(item);
> +       return NULL;
> +}