[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 4 Apr 2016 11:42:59 +0200
From: Michal Hocko <mhocko@...nel.org>
To: Minchan Kim <minchan@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Johannes Weiner <hannes@...xchg.org>
Subject: Re: [PATCH] mm:vmscan: clean up classzone_idx
On Mon 04-04-16 08:46:25, Minchan Kim wrote:
> [1] removed classzone_idx so we don't need code related to it.
> This patch cleans it up.
>
> [1] mm, oom: rework oom detection
As per http://lkml.kernel.org/r/20160404094213.GB13463@dhcp22.suse.cz
the removal of classzone_idx was unintentional and wrong.
>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Michal Hocko <mhocko@...e.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>
> ---
> mm/vmscan.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index d84efa03c8a8..6e67de2a61ed 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2551,16 +2551,8 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
>
> for_each_zone_zonelist_nodemask(zone, z, zonelist,
> gfp_zone(sc->gfp_mask), sc->nodemask) {
> - enum zone_type classzone_idx;
> -
> if (!populated_zone(zone))
> continue;
> -
> - classzone_idx = requested_highidx;
> - while (!populated_zone(zone->zone_pgdat->node_zones +
> - classzone_idx))
> - classzone_idx--;
> -
> /*
> * Take care memory controller reclaiming has small influence
> * to global LRU.
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists