[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 4 Apr 2016 14:10:45 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bert Vermeulen <bert@...t.com>
Cc: Jason Cooper <jason@...edaemon.net>,
Gregory Clement <gregory.clement@...e-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Russell King <linux@....linux.org.uk>,
"moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,..."
<linux-arm-kernel@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: kirkwood: Add DTS for Linksys
EA4200v2/EA4500
On Mon, Apr 04, 2016 at 01:47:12PM +0200, Bert Vermeulen wrote:
> This platform is based on a Marvell 88E6282 SoC and 88E6171 switch.
> ---
Hi Bert
Under the --- it is normal to list what you have changed. That helps
the reviewer focus on just the changes.
> arch/arm/boot/dts/kirkwood-viper.dts | 236 +++++++++++++++++++++++++++++++++++
Please include linksys in the filename.
ls *linksys*
armada-385-linksys-caiman.dts armada-385-linksys.dtsi
armada-385-linksys-cobra.dts armada-xp-linksys-mamba.dts
> 1 file changed, 236 insertions(+)
> create mode 100644 arch/arm/boot/dts/kirkwood-viper.dts
Please add this file to the Makefile. And keep the entries in
alphabetical order.
Otherwise this looks good.
Thanks
Andrew
Powered by blists - more mailing lists