linux-kernel - Re: [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 00:16:53 -0500
From:	Rob Herring <robh@...nel.org>
To:	Guodong Xu <guodong.xu@...aro.org>
Cc:	xuwei5@...ilicon.com, mark.rutland@....com,
	grant.likely@...retlab.ca, linus.walleij@...aro.org,
	arnd.bergmann@...aro.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kong.kongxinwei@...ilicon.com, Chen Feng <puck.chen@...ilicon.com>,
	Fei Wang <w.f@...wei.com>
Subject: Re: [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node

On Sat, Apr 02, 2016 at 05:29:41PM +0800, Guodong Xu wrote:
> From: Chen Feng <puck.chen@...ilicon.com>
> 
> Add the mfd hi655x dts node and regulator support on
> hi6220 platform.
> 
> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> Signed-off-by: Fei Wang <w.f@...wei.com>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com>
> Reviewed-by: Haojian Zhuang <haojian.zhuang@...aro.org>
> Reviewed-by: Guodong Xu <guodong.xu@...aro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 87 ++++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 28bc646..a6dffa8 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -6,6 +6,7 @@
>   */
>  
>  /dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
>  
>  #include "hi6220.dtsi"
>  #include "hikey-gpio.dtsi"
> @@ -104,6 +105,92 @@
>  			default-state = "off";
>  		};
>  	};
> +
> +	pmic: pmic@...00000 {
> +		compatible = "hisilicon,hi655x-pmic";
> +		reg = <0x0 0xf8000000 0x0 0x1000>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> +		status = "okay";
> +
> +		regulators {
> +			ldo2: LDO2@a21 {

@a21 is not a unit address. Please drop these.

> +				regulator-name = "LDO2_2V8";
> +				regulator-min-microvolt = <2500000>;
> +				regulator-max-microvolt = <3200000>;
> +				regulator-enable-ramp-delay = <120>;
> +			};
> +
> +			ldo7: LDO7@a26 {