[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 4 Apr 2016 12:31:00 -0700
From: Kees Cook <keescook@...omium.org>
To: Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc: James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Kalle Valo <kvalo@...eaurora.org>,
Mauro Carvalho Chehab <mchehab@....samsung.com>,
Joe Perches <joe@...ches.com>,
Guenter Roeck <linux@...ck-us.net>,
Jiri Slaby <jslaby@...e.com>, Paul Moore <pmoore@...hat.com>,
Stephen Smalley <sds@...ho.nsa.gov>,
Casey Schaufler <casey@...aufler-ca.com>,
Andreas Gruenbacher <agruenba@...hat.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Ulf Hansson <ulf.hansson@...aro.org>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
linux-security-module <linux-security-module@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] LSM: LoadPin for kernel file loading restrictions
On Thu, Mar 31, 2016 at 2:24 PM, Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> On Mon, 2016-03-28 at 14:14 -0700, Kees Cook wrote:
>
>> +static const char *id_str[READING_MAX_ID] = {
>> + [READING_FIRMWARE] = "firmware",
>> + [READING_MODULE] = "kernel module",
>> + [READING_KEXEC_IMAGE] = "kexec image",
>> + [READING_KEXEC_INITRAMFS] = "kexec initramfs",
>> + [READING_POLICY] = "security policy",
>> +};
>> +
>> +static int loadpin_read_file(struct file *file, enum kernel_read_file_id id)
>> +{
>> + struct super_block *load_root;
>> + const char *origin;
>> +
>> + if (id < 0 || id >= READING_MAX_ID)
>> + return -EINVAL;
>> +
>
> The kernel_read_file_id enumeration starts at 1.
Yeah, I noticed that but decided that since I didn't have a named
value to mark the start, and negative value enums are extremely
unliked, I'd just check against "0" since missing id_str entries will
be correctly identified as "unknown" in the case where id_str and
READING_* enum is out of sync.
>> + origin = id_str[id];
>> + if (!origin) {
>> + origin = "unknown";
>
> Right, all the entries in the kernel_read_file_id enumeration are
> currently listed in id_str. Checking origin is needed for when id_str[]
> isn't kept in sync with the enumeration.
I wonder if there should be a function that returns a const string for
each kernel_read_file_id enum so users of the enum don't need to do
it?
> Looks good!
Thanks! I'll be sending an updated version shortly...
-Kees
--
Kees Cook
Chrome OS & Brillo Security
Powered by blists - more mailing lists