linux-kernel - Re: [PATCH] crypto: document correct return value for request allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 09:27:22 +0200
From:	LABBE Corentin <clabbe.montjoie@...il.com>
To:	Eric Biggers <ebiggers3@...il.com>
Cc:	linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: document correct return value for request
 allocation

On Sat, Apr 02, 2016 at 10:54:56AM -0500, Eric Biggers wrote:
> Signed-off-by: Eric Biggers <ebiggers3@...il.com>
> ---
>  Documentation/DocBook/crypto-API.tmpl | 6 +++---
>  include/crypto/aead.h                 | 3 +--
>  include/crypto/hash.h                 | 3 +--
>  include/crypto/skcipher.h             | 3 +--
>  include/linux/crypto.h                | 3 +--
>  5 files changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/DocBook/crypto-API.tmpl b/Documentation/DocBook/crypto-API.tmpl
> index 348619f..d55dc5a 100644
> --- a/Documentation/DocBook/crypto-API.tmpl
> +++ b/Documentation/DocBook/crypto-API.tmpl
> @@ -1936,9 +1936,9 @@ static int test_skcipher(void)
>  	}
>  
>  	req = skcipher_request_alloc(skcipher, GFP_KERNEL);
> -	if (IS_ERR(req)) {
> -		pr_info("could not allocate request queue\n");
> -		ret = PTR_ERR(req);
> +	if (!req) {
> +		pr_info("could not allocate skcipher request\n");
> +		ret = -ENOMEM;
>  		goto out;
>  	}

Hello

I think pr_err is better than pr_info.

Regards