linux-kernel - Re: [PATCH][RESEND] parport: parport_pc: PCI SIO access should also depend on SIO option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57043ADD.1030402@maciej.szmigiero.name>
Date:	Wed, 6 Apr 2016 00:23:25 +0200
From:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] parport: parport_pc: PCI SIO access should also
 depend on SIO option

Hi Sudip,

On 04.04.2016 18:11, Sudip Mukherjee wrote:
> On Tue, Mar 29, 2016 at 12:00:56AM +0200, Maciej S. Szmigiero wrote:
>> CONFIG_PARPORT_PC_SUPERIO toggles Super IO chip support in parport_pc
>> code, however only code accessing SIO chip via ISA (or LPC) bus was
>> conditional on it.
>>
>> This patch makes SIO chip accesses via PCI bus also dependent on this
>> config option.
>>
>> It should be noted that Super IO support in parport_pc is needed only when
>> firmware has failed to make parallel port available either via PNP or
>> on standard I/O ranges and user has one of a few supported SIOs.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
>> ---
>> This is a resend without functional changes.
> 
> Resend was not required. I had your original patch.
>
> Have you tested it on hardware?

I've tested it with CONFIG_PARPORT_PC_SUPERIO both set and unset,
but on parallel port without one of such SIOs needing special setup.

However, considering that this patch only moves PCI SIO access code
behind this config option (just like ISA one is currently) and doesn't
alter the actual setup functionality I don't expect problems here.

> regards
> sudip

Best regards,
Maciej