linux-kernel - Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 21:02:40 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:	Noam Camus <noamc@...hip.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	guohanjun@...wei.com, xuwei5@...ilicon.com
Subject: Re: [PATCH v3] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

On Tue, Apr 05, 2016 at 11:32:46AM +0800, Kefeng Wang wrote:
> Commit cdcea058e510 ("serial: 8250_dw: Avoid serial_outx code duplicate
> with new dw8250_check_lcr()") introduce a wrong logic when write val to
> LCR reg. When CONFIG_64BIT enabled, __raw_writeq is used unconditionally.
> 
> The __raw_readq/__raw_writeq is introduced by commit bca2092d7897 ("serial:
> 8250_dw: Use 64-bit access for OCTEON.") for OCTEON, so for !PORT_OCTEON,
> we better to use coincident write func.
> 
> Fixes: cdcea058e510("serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
> Keep #ifdef CONFIG_64BIT to ensure it built under arch lacking readq/writeq.
> 
>  drivers/tty/serial/8250/8250_dw.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

What changed between all of these versions?  Always document that below
the --- line otherwise I think they are all the same and I'll just
delete them all :)

v4 please.

thanks,

greg k-h