linux-kernel - Re: [PATCH] intel-iommu: fix up comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160405113819-mutt-send-email-mst@redhat.com>
Date:	Tue, 5 Apr 2016 11:38:27 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Joerg Roedel <joro@...tes.org>,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] intel-iommu: fix up comment

On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
> 
> Cc: Jiang Liu <jiang.liu@...ux.intel.com>
> Suggested-by: Alex Williamson <alex.williamson@...hat.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Anyone?

> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index a2e1b7f..0100553 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1143,7 +1143,7 @@ next:
>  	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
>  }
>  
> -/* free page table pages. last level pte should already be cleared */
> +/* clear last level (leaf) ptes and free page table pages. */
>  static void dma_pte_free_pagetable(struct dmar_domain *domain,
>  				   unsigned long start_pfn,
>  				   unsigned long last_pfn)
> -- 
> MST