linux-kernel - Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570384DA.6010805@arm.com>
Date:	Tue, 5 Apr 2016 10:26:50 +0100
From:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>,
	linux-kernel@...r.kernel.org
Cc:	rt@...utronix.de, Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function
 call

On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call of
> hw_breakpoint_reset(). To keep the calling convention, interrupts are
> explicitely disabled around the call.

While you are at it, could you please also fix a similar instance
in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?

Thanks
Suzuki