linux-kernel - Re: [PATCH] arm64/debug: Remove superfluous SMP function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57039A6B.4080707@cogentembedded.com>
Date:	Tue, 5 Apr 2016 13:58:51 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>,
	linux-kernel@...r.kernel.org
Cc:	Catalin Marinas <catalin.marinas@....com>,
	linux-arm-kernel@...ts.infradead.or, rt@...utronix.de,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] arm64/debug: Remove superfluous SMP function call

Hello.

On 4/4/2016 1:42 PM, Anna-Maria Gleixner wrote:

> Since commit 1cf4f629d9d2 "cpu/hotplug: Move online calls to
> hotplugged cpu" it is ensured that callbacks of CPU_ONLINE and

    scripts/checkpatch.pl now enforces commit citing certain style, yours 
doesn't quite match it, also need parens around quotes enclosing the summary.

> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call to
> clear_os_lock(). The function writes the OSLAR register to clear OS
> locking. This does not require to be called with interrupts disabled,
> therefore the smp_call_function_single() calling convention is not
> preserved.
>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: linux-arm-kernel@...ts.infradead.or
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
[...]

MBR, Sergei