linux-kernel - Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57039EFB.4080508@intel.com>
Date:	Tue, 5 Apr 2016 14:18:19 +0300
From:	Cristina Ciocan <cristina.ciocan@...el.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Irina Tirdea <irina.tirdea@...el.com>,
	Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH v4 6/6] pinctrl: baytrail: Add debounce configuration

On 04.04.2016 17:17, Linus Walleij wrote:
> On Fri, Apr 1, 2016 at 1:00 PM, Cristina Ciocan
> <cristina.ciocan@...el.com> wrote:
> 
>> Make debounce setting and getting functionality available when
>> configurating a certain pin.
>>
>> Signed-off-by: Cristina Ciocan <cristina.ciocan@...el.com>
> 
> Patch applied.
> 
> And as this is another case where GPIO has a debounce
> setting call: gpiod_set_debounce() this is another case for
> my suggested pinctrl_gpio_set_config() as that call is
> currently not implemented in your corresponding .set_debounce()
> callback for the GPIO chip, but could easily be handled
> by calling back into the pinctrl back-end, right?
> 

Yes, it can be easily handled by calling back byt_pin_config_set. I will
look into what other options are often used and would make sense to be
exported in the gpio layer as well and come back with a more detailed
answer.

Thanks