linux-kernel - Re: [PATCH v2 1/4] hwrng: exynos - Runtime suspend device after init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160405124429.GC13048@gondor.apana.org.au>
Date:	Tue, 5 Apr 2016 20:44:29 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Matt Mackall <mpm@...enic.com>, Kukjin Kim <kgene@...nel.org>,
	linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH v2 1/4] hwrng: exynos - Runtime suspend device after init

On Mon, Mar 14, 2016 at 09:07:12AM +0900, Krzysztof Kozlowski wrote:
> The driver uses pm_runtime_put_noidle() after initialization so the
> device might remain in active state if the core does not read from it
> (the read callback contains regular runtime put). The put_noidle() was
> chosen probably to avoid unneeded suspend and resume cycle after the
> initialization.
> 
> However for this purpose autosuspend is enabled so it is safe to runtime
> put just after the initialization.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

All applied.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt