linux-kernel - Re: [PREEMPT-RT] [PATCH] MIPS: Remove no longer needed work_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1604051508030.12514@hypnos>
Date:	Tue, 5 Apr 2016 15:26:11 +0200 (CEST)
From:	Anna-Maria Gleixner <anna-maria@...utronix.de>
To:	Ralf Baechle <ralf@...ux-mips.org>
cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	rt@...utronix.de
Subject: Re: [PREEMPT-RT] [PATCH] MIPS: Remove no longer needed work_on_cpu()
 call

On Mon, 4 Apr 2016, Ralf Baechle wrote:

> On Mon, Apr 04, 2016 at 02:18:03PM +0200, Anna-Maria Gleixner wrote:
> 
> > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this
> > work_on_cpu() calls are no longer required.
> > 
> > Replace work_on_cpu() with a direct call of mips_cdmm_bus_up() or
> > mips_cdmm_bus_down(). Description of those functions are adapted.
> > 
> > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > Cc: linux-mips@...ux-mips.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
> > ---
> >  drivers/bus/mips_cdmm.c |   12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> Thanks, queued for 4.7.
> 

Please do not queue it. Heiko Carstens pointed out a problem: It isn't
ensured, that the callbacks of CPU_DOWN_FAILED are always processed on
the CPU that failed in CPU_DOWN_PREPARE (see
http://marc.info/?l=linux-s390&m=145985621421250&w=2 ). Once this
issue is fixed, I will resend the patch.

Anna-Maria