linux-kernel - Re: [PATCH] iommu: change generic_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160405150408.GF11519@8bytes.org>
Date:	Tue, 5 Apr 2016 17:04:08 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	cn_wyl2003@....com
Cc:	will.deacon@....com, alex.williamson@...hat.com,
	renesas@...nsource.se, yalin.wang2010@...il.com,
	nicolas.iooss_linux@....org, robin.murphy@....com,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu: change generic_device_group function

On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@....com wrote:
> From: yalin wang <yalin.wang2010@...il.com>
> 
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
> 
> Signed-off-by: yalin wang <yalin.wang2010@...il.com>

You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.


	Joerg