linux-kernel - Re: [PATCH v3 0/5] davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5703F1BB.1090401@lechnology.com>
Date:	Tue, 5 Apr 2016 12:11:23 -0500
From:	David Lechner <david@...hnology.com>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski.k@...il.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v3 0/5] davinci_mmc fixes

On 04/05/2016 12:07 PM, David Lechner wrote:
> On 04/05/2016 11:51 AM, David Lechner wrote:
>> On 04/05/2016 06:12 AM, Ulf Hansson wrote:
>>>
>>> Patch 3 triggers a compiler warning, please fix it.
>>>
>>> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’:
>>> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used
>>> uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> I have applied patch 1->2 for next, so no need to resend these.
>>>
>>> Kind regards
>>> Uffe
>>>
>>
>> I am not getting a compiler warning with this commit. Can you please
>> provide a git link so that I can be sure I am building using the same
>> branch that you are using?
>
>
> I think I figured it out. I am applying the patches on top of the next
> branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However, I
> am still not getting a compiler warning. Perhaps it has to do with the
> gcc version. I'm not exactly sure how to fix it since it is really not
> used uninitialized. Just set it to 0 in the variable declaration?

OK. I guess it is my compiler that is broken. :-/
I stared at it long enough and I see the error now.