linux-kernel - [PATCH] cpuidle: Indicate when a device has been unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Apr 2016 14:05:38 -0500
From:	Dave Gerlach <d-gerlach@...com>
To:	<linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>
CC:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Dave Gerlach <d-gerlach@...com>
Subject: [PATCH] cpuidle: Indicate when a device has been unregistered

Currently the 'registered' member of the cpuidle_device struct is set
to 1 during cpuidle_register_device. In this same function there are
checks to see if the device is already registered to prevent duplicate
calls to register the device, but this value is never set to 0 even on
unregister of the device. Because of this, any attempt to call
cpuidle_register_device after a call to cpuidle_unregister_device will
fail which shouldn't be the case.

To prevent this, set registered to 0 when the device is unregistered.

Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
Signed-off-by: Dave Gerlach <d-gerlach@...com>
---
 drivers/cpuidle/cpuidle.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index f996efc56605..c2dd99ab1648 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -433,6 +433,8 @@ static void __cpuidle_unregister_device(struct cpuidle_device *dev)
 	list_del(&dev->device_list);
 	per_cpu(cpuidle_devices, dev->cpu) = NULL;
 	module_put(drv->owner);
+
+	dev->registered = 0;
 }

 static void __cpuidle_device_init(struct cpuidle_device *dev)
-- 
2.7.3