| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1459883865-8225-1-git-send-email-linux@roeck-us.net> Date: Tue, 5 Apr 2016 12:17:45 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Olof Johansson <olof@...om.net> Cc: linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, Gwendal Grignou <gwendal@...omium.org> Subject: [PATCH] platform: chrome: cros_ec_dev - Return number of bytes read with CROS_EC_DEV_IOCRDMEM While ioctls normally return a negative error or 0 on success, this is not the case for CROS_EC_DEV_IOCXCMD in the cros_ec driver, which returns the number of bytes read instead. However, CROS_EC_DEV_IOCRDMEM in the same driver does not return the number of byte read on success. This is both inconsistent and problematic, since the amount of returned data can be dynamic. Have it return the number of data bytes for consistency. Cc: Gwendal Grignou <gwendal@...omium.org> Signed-off-by: Guenter Roeck <linux@...ck-us.net> --- drivers/platform/chrome/cros_ec_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c index d45cd254ed1c..6c45e0f5ba7b 100644 --- a/drivers/platform/chrome/cros_ec_dev.c +++ b/drivers/platform/chrome/cros_ec_dev.c @@ -181,7 +181,7 @@ static long ec_device_ioctl_readmem(struct cros_ec_dev *ec, void __user *arg) if (copy_to_user((void __user *)arg, &s_mem, sizeof(s_mem))) return -EFAULT; - return 0; + return num; } static long ec_device_ioctl(struct file *filp, unsigned int cmd, -- 2.5.0
Powered by blists - more mailing lists