linux-kernel - Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Apr 2016 10:59:58 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:	kbuild-all@...org, Noam Camus <noamc@...hip.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	guohanjun@...wei.com, xuwei5@...ilicon.com,
	Kefeng Wang <wangkefeng.wang@...wei.com>
Subject: Re: [PATCH v2] serial: 8250_dw: fix wrong logic in dw8250_check_lcr()

Hi Kefeng,

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v4.6-rc2 next-20160404]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/serial-8250_dw-fix-wrong-logic-in-dw8250_check_lcr/20160405-104859
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: i386-randconfig-x009-201614 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_dw.c: In function 'dw8250_check_lcr':
>> drivers/tty/serial/8250/8250_dw.c:107:4: error: implicit declaration of function '__raw_writeq' [-Werror=implicit-function-declaration]
       __raw_writeq(value & 0xff, offset);
       ^
   cc1: some warnings being treated as errors

vim +/__raw_writeq +107 drivers/tty/serial/8250/8250_dw.c

6979f8d28 James Hogan 2013-12-10  101  		if ((value & ~UART_LCR_SPAR) == (lcr & ~UART_LCR_SPAR))
c49436b65 Tim Kryger  2013-10-01  102  			return;
cdcea058e Noam Camus  2015-12-12  103  
c49436b65 Tim Kryger  2013-10-01  104  		dw8250_force_idle(p);
cdcea058e Noam Camus  2015-12-12  105  
8158f08d3 Kefeng Wang 2016-04-05  106  		if (IS_ENABLED(CONFIG_64BIT) && p->type == PORT_OCTEON)
cdcea058e Noam Camus  2015-12-12 @107  			__raw_writeq(value & 0xff, offset);
8158f08d3 Kefeng Wang 2016-04-05  108  		else if (p->iotype == UPIO_MEM32)
cdcea058e Noam Camus  2015-12-12  109  			writel(value, offset);
5a43140cc Noam Camus  2015-12-12  110  		else if (p->iotype == UPIO_MEM32BE)

:::::: The code at line 107 was first introduced by commit
:::::: cdcea058e51008479545f29201b4fa577c59733c serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()

:::::: TO: Noam Camus <noamc@...hip.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (22816 bytes)