linux-kernel - Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160405133716.00e0f6ce92dc4bfed50c5334@linux-foundation.org>
Date:	Tue, 5 Apr 2016 13:37:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Minchan Kim <minchan@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Johannes Weiner <hannes@...xchg.org>, stable@...r.kernel.org
Subject: Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is
 over limit

On Mon,  4 Apr 2016 08:46:09 +0900 Minchan Kim <minchan@...nel.org> wrote:

> We have been reclaimed highmem zone if buffer_heads is over limit
> but [1] changed the behavior so it doesn't reclaim highmem zone
> although buffer_heads is over the limit.
> This patch restores the logic.
> 
> [1] commit 6b4f7799c6a5 ("mm: vmscan: invoke slab shrinkers from shrink_zone()")
> 
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2550,7 +2550,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
>  		sc->gfp_mask |= __GFP_HIGHMEM;
>  
>  	for_each_zone_zonelist_nodemask(zone, z, zonelist,
> -					requested_highidx, sc->nodemask) {
> +					gfp_zone(sc->gfp_mask), sc->nodemask) {
>  		enum zone_type classzone_idx;
>  
>  		if (!populated_zone(zone))

Wait wut wot.  We broke this over a year ago?  Highmem pagecache pages
pinning buffer_head lowmem used to be a huuuge problem.  Before most of
you were born ;)