linux-kernel - Re: [PATCH] fs: return EPERM on immutable inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2016 06:44:30 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Eryu Guan <guaneryu@...il.com>
Cc:	linux-fsdevel@...r.kernel.org,
	Steven Whitehouse <swhiteho@...hat.com>,
	Bob Peterson <rpeterso@...hat.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	"supporter:XFS FILESYSTEM" <xfs@....sgi.com>,
	"open list:GFS2 FILE SYSTEM" <cluster-devel@...hat.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: return EPERM on immutable inode

On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only
> a few places returning EACCES. And EPERM looks more reasonable to me.
> 
> So converting all EACCES to EPERM on immutable inode.
> 
> Signed-off-by: Eryu Guan <guaneryu@...il.com>
> ---
> 
> I noticed this when running LTP on overlayfs, setxattr03 failed due to
> unexpected EACCES on immutable inode.

This should be in the commit message itself, rather than "EPERM
looks more reasonable".

Other than that, change seems fine to me.

Acked-by: Dave Chinner <dchinner@...hat.com>
-- 
Dave Chinner
david@...morbit.com