[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5704B0E4.9060300@redhat.com>
Date: Wed, 6 Apr 2016 08:47:00 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Hugh Dickins <hughd@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Andrea Arcangeli <aarcange@...hat.com>,
Andres Lagar-Cavilla <andreslc@...gle.com>,
Yang Shi <yang.shi@...aro.org>, Ning Qu <quning@...il.com>,
linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH 17/31] kvm: teach kvm to map page teams as huge pages.
On 06/04/2016 03:12, Hugh Dickins wrote:
> Hah, you've lighted on precisely a line of code where I changed around
> what Andres had - I thought it nicer to pass down vcpu, because that
> matched the function above, and in many cases vcpu is not dereferenced
> here at all. So, definitely blame me not Andres for that interface.
>
Oh, actually I'm fine with the interface if it's in arch/x86/kvm. I'm
just pointing out that---putting aside the locking question---it's a
pretty generic thing that doesn't really need access to KVM data structures.
Paolo
Powered by blists - more mailing lists