linux-kernel - Re: [PATCH] libnvdimm, nfit: report multiple interface codes per-dimm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Apr 2016 10:22:47 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-nvdimm@...ts.01.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libnvdimm, nfit: report multiple interface codes per-dimm

On 2016-04-06 02:35, Dan Williams wrote:
> Starting with ACPI 6.1 an NFIT table will report multiple 'NVDIMM
> Control Region Structure' instances per-dimm, one for each supported
> format interface.  Report that code in the following format in sysfs:
> 
>     nmemX/nfit/formats
>     nmemX/nfit/format
>     nmemX/nfit/format1
>     nmemX/nfit/format2
>     ...
>     nmemX/nfit/formatN
> 
> Where format2 - formatN are theoretical as there are no known DIMMs 
> with
> support for more than two interface formats.
> 
> This layout is compatible with existing libndctl binaries that only
> expect one code per-dimm as they will ignore nmemX/nfit/formats and
> nmemX/nfit/formatN.
> 
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Looks OK to me
Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>