linux-kernel - Re: [PATCH] cpuset: use static key better and convert to new API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2016 16:56:43 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	kbuild-all@...org, Li Zefan <lizefan@...wei.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Peter Zijlstra <peterz@...radead.org>,
	David Rientjes <rientjes@...gle.com>, cgroups@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] cpuset: use static key better and convert to new API

Hi Vlastimil,

[auto build test WARNING on v4.6-rc2]
[also build test WARNING on next-20160406]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Vlastimil-Babka/cpuset-use-static-key-better-and-convert-to-new-API/20160406-164542
config: x86_64-randconfig-x007-201614 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from mm/page_alloc.c:17:
   mm/page_alloc.c: In function 'get_page_from_freelist':
   mm/page_alloc.c:2653:5: error: implicit declaration of function '__cpuset_zone_allowed' [-Werror=implicit-function-declaration]
       !__cpuset_zone_allowed(zone, gfp_mask))
        ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^
>> mm/page_alloc.c:2651:3: note: in expansion of macro 'if'
      if (cpusets_enabled() &&
      ^
   cc1: some warnings being treated as errors

vim +/if +2651 mm/page_alloc.c

7fb1d9fca Rohit Seth       2005-11-13  2635  	struct page *page = NULL;
5117f45d1 Mel Gorman       2009-06-16  2636  	struct zone *zone;
4ffeaf356 Mel Gorman       2014-08-06  2637  	int nr_fair_skipped = 0;
4ffeaf356 Mel Gorman       2014-08-06  2638  	bool zonelist_rescan;
54a6eb5c4 Mel Gorman       2008-04-28  2639  
9276b1bc9 Paul Jackson     2006-12-06  2640  zonelist_scan:
4ffeaf356 Mel Gorman       2014-08-06  2641  	zonelist_rescan = false;
4ffeaf356 Mel Gorman       2014-08-06  2642  
7fb1d9fca Rohit Seth       2005-11-13  2643  	/*
9276b1bc9 Paul Jackson     2006-12-06  2644  	 * Scan zonelist, looking for a zone with enough free.
344736f29 Vladimir Davydov 2014-10-20  2645  	 * See also __cpuset_node_allowed() comment in kernel/cpuset.c.
7fb1d9fca Rohit Seth       2005-11-13  2646  	 */
a9263751e Vlastimil Babka  2015-02-11  2647  	for_each_zone_zonelist_nodemask(zone, z, zonelist, ac->high_zoneidx,
a9263751e Vlastimil Babka  2015-02-11  2648  								ac->nodemask) {
e085dbc52 Johannes Weiner  2013-09-11  2649  		unsigned long mark;
e085dbc52 Johannes Weiner  2013-09-11  2650  
664eeddee Mel Gorman       2014-06-04 @2651  		if (cpusets_enabled() &&
664eeddee Mel Gorman       2014-06-04  2652  			(alloc_flags & ALLOC_CPUSET) &&
a8f315757 Vlastimil Babka  2016-04-06  2653  			!__cpuset_zone_allowed(zone, gfp_mask))
cd38b115d Mel Gorman       2011-07-25  2654  				continue;
a756cf590 Johannes Weiner  2012-01-10  2655  		/*
81c0a2bb5 Johannes Weiner  2013-09-11  2656  		 * Distribute pages in proportion to the individual
81c0a2bb5 Johannes Weiner  2013-09-11  2657  		 * zone size to ensure fair page aging.  The zone a
81c0a2bb5 Johannes Weiner  2013-09-11  2658  		 * page was allocated in should have no effect on the
81c0a2bb5 Johannes Weiner  2013-09-11  2659  		 * time the page has in memory before being reclaimed.

:::::: The code at line 2651 was first introduced by commit
:::::: 664eeddeef6539247691197c1ac124d4aa872ab6 mm: page_alloc: use jump labels to avoid checking number_of_cpusets

:::::: TO: Mel Gorman <mgorman@...e.de>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (29341 bytes)