linux-kernel - Re: [PATCH v7 05/20] PM / devfreq: Add new passive governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <1156624937.169371459937164322.JavaMail.weblogic@ep2mlwas02a>
Date:	Wed, 06 Apr 2016 10:06:10 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	최찬우 <cw00.choi@...sung.com>,
	박경민 <kyungmin.park@...sung.com>,
	크쉬시토프 
	<k.kozlowski@...sung.com>, "kgene@...nel.org" <kgene@...nel.org>
Cc:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux.amoon@...il.com" <linux.amoon@...il.com>,
	"m.reichl@...etechno.de" <m.reichl@...etechno.de>,
	"tjakobi@...h.uni-bielefeld.de" <tjakobi@...h.uni-bielefeld.de>,
	대인기 <inki.dae@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 05/20] PM / devfreq: Add new passive governor

>   
>  This patch adds the new passive governor for DEVFREQ framework. The following
> governors are already present and used for DVFS (Dynamic Voltage and Frequency
> Scaling) drivers. The following governors are independently used for one device
[]
> Suggested-by: Myungjoo Ham <myungjoo.ham@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> [tjakobi: Reported RCU locking issue and cw00.choi fix it.]
> Reported-by: Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>

Signed-off-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Please just edit the comment below and push to your git repo so that
I can simply pull your repo a day or two later.

> ---
>  drivers/devfreq/Kconfig            |   8 ++
>  drivers/devfreq/Makefile           |   1 +
>  drivers/devfreq/governor_passive.c | 206 +++++++++++++++++++++++++++++++++++++
>  include/linux/devfreq.h            |  33 ++++++
>  4 files changed, 248 insertions(+)
>  create mode 100644 drivers/devfreq/governor_passive.c
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index cedda8f1e5eb..d260cd0219f6 100644
[]
> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
> index 8af8aaf922a8..2633087d5c63 100644
[]
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> +	/*
> +	 * If the parent and passive devfreq device uses the OPP table,
> +	 * get the next frequency by using the OPP table.

Doesn't need comments from here
> +	 * - parent devfreq device uses the governors except for passive.
> +	 * - passive devfreq device uses the passive governor.
> +	 */
> +
> +	/*
To here.

> +	 * Each devfreq has the OPP table. After deciding the new frequency
> +	 * from the governor of parent devfreq device, the passive governor
> +	 * need to get the index of new frequency on OPP table of parent
> +	 * device. And then the index is used for getting the suitable
> +	 * new frequency for passive devfreq device.
> +	 */

[]

> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
> index 98c699304e12..2de4e2eea180 100644
[]