linux-kernel - Re: [PATCH] staging: comedi: das1800: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5704E7B8.6000707@mev.co.uk>
Date:	Wed, 6 Apr 2016 11:40:56 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: comedi: das1800: remove unused variable

On 06/04/16 10:41, Ian Abbott wrote:
> On 06/04/16 02:21, Hartley Sweeten wrote:
>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>> The variable unipolar was never used.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
>>> ---
>>>
>>> There may be a chance that reading from DAS1800_CONTROL_C is necessary
>>> before reading from DAS1800_STATUS. If that is true then please discard
>>> this patch.
>>
>> Actually the driver has a bug here.
>>
>> The analog input samples should  be munged if the inputs are
>> configured for
>> bipolar mode.
>>
>> I have a series almost ready that cleans up this driver and fixes the
>> bug.
>
> Hi Hartley, can the bug fix be placed at the top of your patch series?
> Thanks.
>

The bug has been there forever (even in the "out-of-tree" version from 
comedi.org, where I have just fixed it). There have been patches applied 
to reformat and remove the incorrect bits of code, including 
a142785d7c9d ("Staging: comedi: das1800: fixed multiple brace coding 
style issues and pointer declaration style errors") and 82d28561b7e0 
("staging: comedi: Remove if condition.").  The latter patch, 
82d28561b7e0, mainly served to hide the bug further!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-