linux-kernel - Re: [PATCH] mmc: Remove some redundant debug prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160406195732.67430c96@xhacker>
Date:	Wed, 6 Apr 2016 19:57:32 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	Baolin Wang <baolin.wang@...aro.org>
CC:	<ulf.hansson@...aro.org>, <adrian.hunter@...el.com>,
	<rmk+kernel@....linux.org.uk>, <shawn.lin@...k-chips.com>,
	<dianders@...omium.org>, <david@...tonic.nl>, <broonie@...nel.org>,
	<linus.walleij@...aro.org>, <takahiro.akashi@...aro.org>,
	<linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: Remove some redundant debug prints



On Wed,  6 Apr 2016 19:38:30 +0800 Baolin Wang wrote:

> This patch removes some redundant debug prints, since we have added some
> tracepoints to help with performance analysis of MMC subsystem.

I think the debug prints you removed are useful for debugging mmc err, how is
this purpose achieved by tracepoints? From another side, why should I enable
tracepoints to debug mmc err?

Thanks

> 
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---
>  drivers/mmc/core/core.c |   52 -----------------------------------------------
>  1 file changed, 52 deletions(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index f80b3ab..3f1362a 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>  
>  		led_trigger_event(host->led, LED_OFF);
>  
> -		if (mrq->sbc) {
> -			pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
> -				mmc_hostname(host), mrq->sbc->opcode,
> -				mrq->sbc->error,
> -				mrq->sbc->resp[0], mrq->sbc->resp[1],
> -				mrq->sbc->resp[2], mrq->sbc->resp[3]);
> -		}
> -
> -		pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
> -			mmc_hostname(host), cmd->opcode, err,
> -			cmd->resp[0], cmd->resp[1],
> -			cmd->resp[2], cmd->resp[3]);
> -
> -		if (mrq->data) {
> -			pr_debug("%s:     %d bytes transferred: %d\n",
> -				mmc_hostname(host),
> -				mrq->data->bytes_xfered, mrq->data->error);
> -		}
> -
> -		if (mrq->stop) {
> -			pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
> -				mmc_hostname(host), mrq->stop->opcode,
> -				mrq->stop->error,
> -				mrq->stop->resp[0], mrq->stop->resp[1],
> -				mrq->stop->resp[2], mrq->stop->resp[3]);
> -		}
> -
>  		if (mrq->done)
>  			mrq->done(mrq);
>  	}
> @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>  	if (mmc_card_removed(host->card))
>  		return -ENOMEDIUM;
>  
> -	if (mrq->sbc) {
> -		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
> -			 mmc_hostname(host), mrq->sbc->opcode,
> -			 mrq->sbc->arg, mrq->sbc->flags);
> -	}
> -
> -	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
> -		 mmc_hostname(host), mrq->cmd->opcode,
> -		 mrq->cmd->arg, mrq->cmd->flags);
> -
> -	if (mrq->data) {
> -		pr_debug("%s:     blksz %d blocks %d flags %08x "
> -			"tsac %d ms nsac %d\n",
> -			mmc_hostname(host), mrq->data->blksz,
> -			mrq->data->blocks, mrq->data->flags,
> -			mrq->data->timeout_ns / 1000000,
> -			mrq->data->timeout_clks);
> -	}
> -
> -	if (mrq->stop) {
> -		pr_debug("%s:     CMD%u arg %08x flags %08x\n",
> -			 mmc_hostname(host), mrq->stop->opcode,
> -			 mrq->stop->arg, mrq->stop->flags);
> -	}
> -
>  	WARN_ON(!host->claimed);
>  
>  	mrq->cmd->error = 0;