linux-kernel - RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y48q2adb.fsf@intel.com>
Date:	Wed, 06 Apr 2016 15:24:32 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	"Du\, Changbin" <changbin.du@...el.com>,
	Greg KH <gregkh@...uxfoundation.org>
Cc:	"linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space


Hi,

(please make sure to break your lines at
80-characters. Documentation/email-clients.txt has several tips for
different email clients ;-))

"Du, Changbin" <changbin.du@...el.com> writes:
>> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
>> >  		goto err1;
>> >  	}
>> >
>> > +	file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
>> &dwc3_fifo_fops);
>> > +	if (!file) {
>> > +		ret = -ENOMEM;
>> 
>> Um, no, that's not the error here.  You shouldn't care at all about
>> debugfs api call results.  Just keep moving on here please.
>> 
>> thanks,
>> 
>> greg k-h
>
> Agree with you. I will create another patch to cleanup this piece of
> code.

cool, thanks

> And I found a memory leak issue there, dwc->regset never
> released. Will also fix it.

good catch, thanks for fixing it.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)