lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2016 15:32:49 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Nicholas Sim <nicholassimws@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: rts5208: ensure braces on all arms of if stmt On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote: > Added braces on if arm of if statement where else arm already needs braces > as suggested for clarity in Documentation/CodingStyle > > Signed-off-by: Nicholas Sim <nicholassimws@...il.com> > --- > drivers/staging/rts5208/ms.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c > index 3e75db7..2ad4ea0 100644 > --- a/drivers/staging/rts5208/ms.c > +++ b/drivers/staging/rts5208/ms.c > @@ -794,8 +794,9 @@ static int ms_confirm_cpu_startup(struct rtsx_chip *chip) > } > > if (val & INT_REG_ERR) { > - if (val & INT_REG_CMDNK) > + if (val & INT_REG_CMDNK) { > chip->card_wp |= (MS_CARD); > + } > else { It should be } else { on one line. regards, dan carpenter http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Powered by blists - more mailing lists